Skip already moved packages #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR prevents moving a file more than once, but I think it doesn't stop the duplicate files from being processed with the replacer more than once. The result is that you get namespaces with repeated prefixes added to them, and they no longer match the directory location. |
|
@zengenuity The regex that is used to add the prefixed namespaces should take care of that. This is simply for not trying to move them twice. If you have issues with duplicate namespace prefixes, please report this in a separate issue, providing steps to reproduce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can go in the next fix release. Each package should only be moved/replaced once, even if the full dependency tree has the same package multiple times. Fixes #17.